Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a copy file of sca.json when scan runnig with ScaResolver (AST-48074) #924

Merged
merged 15 commits into from
Nov 12, 2024

Conversation

Korjen97
Copy link
Contributor

@Korjen97 Korjen97 commented Nov 4, 2024

…lver

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Remove the scaResultsFile after remove the .json suffix

References

https://checkmarx.atlassian.net/browse/AST-48074

Testing

Unit Test (TestRunScaResolverAndAddScaResultsFileCleanup)
Mock Setup: Defined mock values for sourceDir, scaResolver, and projectName.
Function Execution: Called runScaResolver with the mock inputs.
File Deletion Check: Verified that the temporary file was deleted using os.Stat and os.IsNotExist, ensuring that the cleanup process worked as expected.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team November 4, 2024 09:48
@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2024
@Korjen97 Korjen97 changed the title bug/itay/remove sca resolver file (AST-48074) Bug/itay/remove sca resolver file (AST-48074) Nov 4, 2024
@Korjen97 Korjen97 changed the title Bug/itay/remove sca resolver file (AST-48074) Deleting a copy file of sca.json when scan runnig with ScaResolver (AST-48074) Nov 5, 2024
Copy link

github-actions bot commented Nov 7, 2024

Logo
Checkmarx One – Scan Summary & Details2fb271d4-e398-4d35-96b3-a40499fc6a03

No New Or Fixed Issues Found

OrShamirCM
OrShamirCM previously approved these changes Nov 7, 2024
@OrShamirCM OrShamirCM merged commit d8e3069 into main Nov 12, 2024
9 checks passed
@OrShamirCM OrShamirCM deleted the Bug/Itay/Remove-sca-resolver-file branch November 12, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants